-
Notifications
You must be signed in to change notification settings - Fork 806
Chore: Drop support for Python 3.8 #3399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...us-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/gogoproto/gogo_pb2.py
Show resolved
Hide resolved
26c0f26 to
71eb61e
Compare
fba15e8 to
e2360f6
Compare
...metry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/lmbd.py
Outdated
Show resolved
Hide resolved
e2360f6 to
4f57fa3
Compare
...pentelemetry-instrumentation-boto3sqs/src/opentelemetry/instrumentation/boto3sqs/__init__.py
Outdated
Show resolved
Hide resolved
4f57fa3 to
415fb0c
Compare
5e91bf0 to
cbac8ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have preferred to decouple bumping the baseline to the changes to the other hundreds of files 😅
.github/workflows/generate_workflows_lib/src/generate_workflows_lib/__init__.py
Outdated
Show resolved
Hide resolved
Agree - it's why this is still in draft. |
81f758e to
b5dbc7b
Compare
b5dbc7b to
7af57d4
Compare
instrumentation/opentelemetry-instrumentation-psycopg/pyproject.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jomcgi I think we need to merge this first, and then merge -core. Do you think the -core PR is ready to review?
I'm fine with this PR once the comments are addressed.
44b2f31 to
b012adf
Compare
Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support ended on 2024-04-07. Changes: * Updated basline refs to 3.9 * Removed 3.8 sys.version_info checks * Fixed botocore test failure * Applied ruff formatting
b012adf to
983847a
Compare
|
Resolved open comments & rebased PR.
No - I can start looking at it now that this is up to date. |
|
Note to self: before merging this we need to remove the 3.8 jobs from jobs required to have a green CI UPDATE: Done, once merged need to add pypy-3.9 entries |
Description
Python 3.8 was EoL @ 2024-10-07, our 6 month promise for support will end @ 2024-04-07.
Changes:
Fixes open-telemetry/opentelemetry-python#4513
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.